Add ImageIOBase::GetComponentTypeFromTypeTraits(isFloatingPoint, isUnsigned, numberOfBits)#5449
Merged
hjmjohnson merged 2 commits intoInsightSoftwareConsortium:mainfrom Jul 10, 2025
Conversation
Aims to ease retrieving the appropriate pixel component type, by calling `GetComponentTypeFromTypeTraits(isFloatingPoint, isUnsigned, numberOfBits)` (possibly at compile-time).
github-actions
bot
added
type:Testing
Member
|
As explained in the discourse post, I believe the "CHAR" enum type should be considered signed, and the cases there it is system dependent on the C "char" type should be considered a bug. |
Reduced code redundancy in `MetaImageIO::ReadImageInformation()`, by removing the 48 `this->SetComponentType` calls from its `switch`.
N-Dekker
force-pushed
the
ImageIOBase-GetComponentTypeFromTypeTraits
branch
from
789fda9 to
2d05d9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a static member function,
ImageIOBase::GetComponentTypeFromTypeTraits(bool isFloatingPoint, bool isUnsigned, size_t numberOfBits), to ease retrieving the appropriate pixel component type.Used this member function to clean up
MetaImageIO::ReadImageInformation(), by removing the 48this->SetComponentTypecalls from itsswitch.