Add IOComponent enum SCHAR for signed char (equivalent to CHAR)#5473
Merged
dzenanz merged 2 commits intoInsightSoftwareConsortium:mainfrom Jul 25, 2025
Merged
Add IOComponent enum SCHAR for signed char (equivalent to CHAR)#5473dzenanz merged 2 commits intoInsightSoftwareConsortium:mainfrom
IOComponent enum SCHAR for signed char (equivalent to CHAR)#5473dzenanz merged 2 commits intoInsightSoftwareConsortium:mainfrom
Conversation
The name `SCHAR` appears clearer than `CHAR`, because it is intended to specify a _signed_ char type. The abbreviation `SCHAR` is already used to denote `signed char` in C and C++ (`SCHAR_MAX`) as well as in HDF5 (`H5T_NATIVE_SCHAR`).
Aims to clarify that those cases deal with a `signed` char type.
github-actions
bot
added
type:Testing
Contributor
Author
|
The failure of ITK.Pixi / Pixi-Cxx (windows-2022) (pull_request) seems unrelated. It says: Does anyone have a clue? |
Member
|
It does not look like this CI job submits to cdash for does it display the output of the test when it fails. There is not much information to go on. |
Contributor
Author
Thanks so far, @blowekamp I just ran the test locally, on Windows 11/VS2022, and it passes successfully, on my PR branch (IOComponent-SCHAR): |
Contributor
Author
|
itkBinaryMorphologicalOpeningImageFilterTest fails on the main branch as well! "ITK.Pixi / Pixi-Cxx (windows-2022) (push)", main branch commit f71cfd8 |
dzenanz
merged commit d0b0706
into
InsightSoftwareConsortium:main
19 of 22 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced
CHARwithSCHARinIOComponentEnum::CHARcases ofswitchstatements.The name
SCHARappears clearer thanCHAR, because it is intended to specify a signed char type. The abbreviationSCHARis already used to denotesigned charin C and C++ (SCHAR_MAX) as well as in HDF5 (H5T_NATIVE_SCHAR).