BUG: VTKPolyDataMeshIO should use signed char for the SCHAR cases#5548
Merged
thewtex merged 1 commit intoInsightSoftwareConsortium:mainfrom Oct 13, 2025
Merged
Conversation
`VTKPolyDataMeshIO` originally casted the `buffer` to plain `char *` for component type `SCHAR`. However, `SCHAR` indicates that the component type is _signed_ char. Follow-up to pull request InsightSoftwareConsortium#5470 commit 70fbb2b "BUG: MINCImageIO should use `signed char` for `CHAR` and `MI_TYPE_BYTE`"
github-actions
bot
added
type:Bug
dzenanz
approved these changes
Oct 10, 2025
Member
|
/azp run ITK.Linux |
Member
|
/azp run ITK.Windows |
thewtex
approved these changes
Oct 13, 2025
thewtex
merged commit cb07a31
into
InsightSoftwareConsortium:main
17 of 22 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VTKPolyDataMeshIOoriginally casted thebufferto plainchar *for component typeSCHAR. However,SCHARindicates that the component type is signed char.Follow-up to pull request #5470 commit 70fbb2b "BUG: MINCImageIO should use
signed charforCHARandMI_TYPE_BYTE"