BUG: Removing open HDF5 files causes segmentation fault#5784
Merged
hjmjohnson merged 1 commit intomainfrom Feb 11, 2026
Merged
Conversation
github-actions
bot
added
type:Bug
10 tasks
dzenanz
approved these changes
Feb 9, 2026
Member
dzenanz
left a comment
dzenanz
left a comment
There was a problem hiding this comment.
Thank you Hans. Looks tricky.
For possible other reviewers: turn on "hide whitespace", hidden under the gear in top-right corner on GitHub.
Member
Author
|
\azp ITK.macOS.Python |
Member
Author
|
/azp ITK.macOS.Python |
hjmjohnson
force-pushed
the
hdf5-test-file-close-test-failure
branch
from
dc69026 to
e8e7ba9
Compare
There was a problem hiding this comment.
Pull request overview
Fixes a segfault in the HDF5 streaming read/write test by ensuring HDF5-backed pipeline objects are destroyed (and thus their file handles closed) before attempting to delete the output file.
Changes:
- Wraps streaming writer/reader pipeline objects in an isolation scope to force destructor execution before cleanup.
- Updates/expands comments explaining why the isolation scope is needed.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
blowekamp
approved these changes
Feb 11, 2026
Member
blowekamp
left a comment
blowekamp
left a comment
There was a problem hiding this comment.
LGTM, Copilot suggested could be applied.
Added an isolation block for the streaming readers and writers. For streaming to work, both the ReaderImageFilter and the WriteImageFilter will maintain handles to open HDF5 files Until their destructors are run. Enhanced comments for better readability and maintainability.
hjmjohnson
force-pushed
the
hdf5-test-file-close-test-failure
branch
from
99bd966 to
d155450
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an isolation block for the streaming readers and writers.
For streaming to work, both the ReaderImageFilter and the
WriteImageFilter will maintain handles to open HDF5 files
Until their destructors are run.
Enhanced comments for better readability and maintainability.
This failure exposed itself during debugging of PR:
PR Checklist