ENH: Always finalize CDash submission so PR "CDash" check leaves in-progress

[hjmjohnson]

Adds an unconditional final ctest_submit(PARTS Done) so CDash's done column is always set to 1, which lets the open-cdash-org GitHub App flip the per-PR "CDash" check from in_progress to success / failure instead of leaving it pending forever.

Resolves #6140. Most recently observed on #6137: all five Azure pipelines passed, CDash showed every build row green, but the CDash PR check still sat at pending because the plain Linux build's row had done = 0 (its in-loop ctest_submit() evidently dropped the Done part on a transient HTTPS error and was never retried).

Why the existing single submit isn't enough

Reading the App code at Kitware/CDash/app/cdash/app/Lib/Repository/GitHub.php (getCheckSummaryForBuildRow):

} else {
    if ((int) $row['done'] === 1) {
        // Build completed without problems.
        $icon = ':white_check_mark:';
        $msg = 'success';
        $this->numPassed++;
    } else {
        // Build hasn't finished reporting yet.
        $icon = ':hourglass_flowing_sand:';
        $msg = 'pending';
        $this->numPending++;
        // Schedule this check to re-run when the build is finished.
        PendingSubmissions::where('buildid', (int) $row['id'])->update([
            'recheck' => true,
        ]);
    }
}

While numPending > 0, generateCheckPayloadFromBuildRows keeps the check at status: in_progress. The recheck only fires when another submission lands for the same build — and after a failed HTTPS submit no further submission ever comes, so the check stays pending until manually retried.

What this PR changes

Two small additions in itk_common.cmake:

1. The in-loop ctest_submit() gains RETRY_COUNT 3 RETRY_DELAY 30 and captures the return value, with a warning if it fails.
2. After the loop ends — and before the post-loop diagnostics that may call message(FATAL_ERROR …) — an unconditional ctest_submit(PARTS Done RETRY_COUNT 5 RETRY_DELAY 60) runs. This is what flips done to 1 in the CDash database and is what the App needs to complete the PR check.

Both calls are gated on the existing dashboard_no_submit flag, so experimental builds that never want to upload still don't.

[hjmjohnson]

@greptileai review this draft before I make it official

[greptile-apps]

Greptile Summary

This PR adds RETRY_COUNT/RETRY_DELAY to the in-loop ctest_submit() and inserts an unconditional ctest_submit(PARTS Done) after the dashboard loop (but before any message(FATAL_ERROR)) to reliably set CDash's done = 1 column, allowing the open-cdash-org GitHub App to transition the "CDash" PR check out of in_progress. Both additions are correctly gated on dashboard_no_submit.

Confidence Score: 5/5

Safe to merge — the change is minimal, well-scoped, and correctly gated on the existing dashboard_no_submit flag.

Only a P2 wording nit was found. The logic is sound: the Done sentinel is placed before any FATAL_ERROR call so it fires even on build failures, retries are tuned appropriately, and experimental builds that opt out of submitting are unaffected.

No files require special attention.

Important Files Changed

Filename	Overview
itk_common.cmake	Adds retry logic to in-loop ctest_submit and an unconditional post-loop ctest_submit(PARTS Done) to reliably flip CDash's done=1 flag; only a minor warning-message wording nit found.

Sequence Diagram

sequenceDiagram
    participant CI as CI Runner
    participant CM as itk_common.cmake
    participant CDash
    participant GHApp as open-cdash-org App
    participant GH as GitHub Checks

    loop dashboard loop iterations
        CI->>CM: run build/test steps
        CM->>CDash: ctest_submit(RETRY_COUNT 3 RETRY_DELAY 30)
        alt submit fails after 3 retries
            CM-->>CI: WARNING (step results may be missing)
        else submit succeeds
            CDash-->>CM: OK (done=0 per row)
        end
    end

    Note over CM: loop exits (one-shot or continuous)

    CM->>CDash: ctest_submit(PARTS Done, RETRY_COUNT 5 RETRY_DELAY 60)
    CDash-->>CM: done=1 set on build row
    CDash->>GHApp: trigger recheck via PendingSubmissions
    GHApp->>GH: update check to success / failure

Loading

_{Reviews (2): Last reviewed commit: "ENH: Always finalize CDash submission so..." | Re-trigger Greptile}