ENH: Simpler TransformPhysicalPointToContinuousIndex(point) overloads (rebase of #4002)

Modules/Core/Common/include/itkImageAlgorithm.hxx

@@ -277,8 +277,7 @@ ImageAlgorithm::EnlargeRegionOverBox(const typename InputImageType::RegionType &
         outputPoint[d] = inputPoint[d];
       }
     }
-    outputCorners[count] =
-      outputImage->template TransformPhysicalPointToContinuousIndex<ContinuousIndexValueType>(outputPoint);
+    outputCorners[count] = outputImage->TransformPhysicalPointToContinuousIndex(outputPoint);
   }
 
   // Compute a rectangular region from the vector of corner indexes

Modules/Core/Common/include/itkImageBase.h

@@ -531,6 +531,17 @@ class ITK_TEMPLATE_EXPORT ImageBase : public DataObject
     return index;
   }
 
+  /** \brief Returns the continuous index from a physical point
+   * \note This non-template overload is easier to use, because it does not have template arguments. It uses
+   * `itk::SpacePrecisionType` both for the coordinates of the point and the values of the index.
+   *
+   * \sa Transform */
+  [[nodiscard]] ContinuousIndex<SpacePrecisionType, VImageDimension>
+  TransformPhysicalPointToContinuousIndex(const PointType & point) const
+  {
+    return TransformPhysicalPointToContinuousIndex<SpacePrecisionType>(point);
+  }
+
   /** \brief Get the continuous index from a physical point
    *
    * Returns true if the resulting index is within the image, false otherwise.

Modules/Core/Common/include/itkPhasedArray3DSpecialCoordinatesImage.h

@@ -208,6 +208,17 @@ class ITK_TEMPLATE_EXPORT PhasedArray3DSpecialCoordinatesImage : public SpecialC
     return index;
   }
 
+  /** \brief Returns the continuous index from a physical point
+   * \note This non-template overload is easier to use, because it does not have template arguments. It uses
+   * `itk::SpacePrecisionType` both for the coordinates of the point and the values of the index.
+   *
+   * \sa Transform */
+  [[nodiscard]] ContinuousIndex<SpacePrecisionType, 3>
+  TransformPhysicalPointToContinuousIndex(const PointType & point) const
+  {
+    return TransformPhysicalPointToContinuousIndex<SpacePrecisionType>(point);
+  }
+
   /** \brief Get the continuous index from a physical point
    *
    * Returns true if the resulting index is within the image, false otherwise.

Modules/Core/ImageAdaptors/include/itkImageAdaptor.h

@@ -402,6 +402,17 @@ class ITK_TEMPLATE_EXPORT ImageAdaptor : public ImageBase<TImage::ImageDimension
     return m_Image->template TransformPhysicalPointToContinuousIndex<TIndexRep>(point);
   }
 
+  /** \brief Returns the continuous index from a physical point
+   * \note This non-template overload is easier to use, because it does not have template arguments. It uses
+   * `itk::SpacePrecisionType` both for the coordinates of the point and the values of the index.
+   *
+   * \sa Transform */
+  [[nodiscard]] ContinuousIndex<SpacePrecisionType, TImage::ImageDimension>
+  TransformPhysicalPointToContinuousIndex(const PointType & point) const
+  {
+    return m_Image->TransformPhysicalPointToContinuousIndex(point);
+  }
+
   /** \brief Get the continuous index from a physical point
    *
    * Returns true if the resulting index is within the image, false otherwise.

Modules/Core/Mesh/include/itkTriangleMeshToBinaryImageFilter.hxx

@@ -341,7 +341,7 @@ TriangleMeshToBinaryImageFilter<TInputMesh, TOutputImage>::RasterizeTriangles()
   while (points != myPoints->End())
   {
     const PointType p = points.Value();
-    // the index value type must match the point value type
+    // Explicit <PointType::ValueType> keeps the index in the mesh's point precision.
     const ContinuousIndex<PointType::ValueType, 3> ind =
       OutputImage->template TransformPhysicalPointToContinuousIndex<PointType::ValueType>(p);
     NewPoints->InsertElement(pointId++, ind);

Modules/Core/Transform/include/itkBSplineBaseTransform.hxx

@@ -230,6 +230,7 @@ BSplineBaseTransform<TParametersValueType, VDimension, VSplineOrder>::
                                                          WeightsType &             weights,
                                                          ParameterIndexArrayType & indexes) const
 {
+  // Explicit <TParametersValueType> keeps the index in parametric precision under ITK_USE_FLOAT_SPACE_PRECISION=ON.
   ContinuousIndexType index =
     this->m_CoefficientImages[0]->template TransformPhysicalPointToContinuousIndex<TParametersValueType>(point);
 

Modules/Filtering/ImageGrid/include/itkWarpImageFilter.hxx

@@ -183,6 +183,7 @@ WarpImageFilter<TInputImage, TOutputImage, TDisplacementField>::EvaluateDisplace
   const DisplacementFieldType * fieldPtr,
   DisplacementType &            output)
 {
+  // Explicit <double> keeps the index in double precision under ITK_USE_FLOAT_SPACE_PRECISION=ON.
   const ContinuousIndex<double, ImageDimension> index =
     fieldPtr->template TransformPhysicalPointToContinuousIndex<double>(point);
   /**

Modules/Registration/Common/include/itkImageToImageMetric.hxx

@@ -988,7 +988,7 @@ ImageToImageMetric<TFixedImage, TMovingImage>::ComputeImageDerivatives(const Mov
     if (m_ComputeGradient)
     {
       const ContinuousIndex<double, MovingImageDimension> tempIndex =
-        m_MovingImage->template TransformPhysicalPointToContinuousIndex<double>(mappedPoint);
+        m_MovingImage->TransformPhysicalPointToContinuousIndex(mappedPoint);
       MovingImageIndexType mappedIndex;
       mappedIndex.CopyWithRound(tempIndex);
       gradient = m_GradientImage->GetPixel(mappedIndex);

Modules/Registration/Common/include/itkKappaStatisticImageToImageMetric.hxx

@@ -247,7 +247,7 @@ KappaStatisticImageToImageMetric<TFixedImage, TMovingImage>::GetDerivative(const
       using MovingImageContinuousIndexType = ContinuousIndex<CoordinateType, MovingImageType::ImageDimension>;
 
       const MovingImageContinuousIndexType tempIndex =
-        this->m_MovingImage->template TransformPhysicalPointToContinuousIndex<CoordinateType>(transformedPoint);
+        this->m_MovingImage->TransformPhysicalPointToContinuousIndex(transformedPoint);
 
       typename MovingImageType::IndexType mappedIndex;
       mappedIndex.CopyWithRound(tempIndex);

Modules/Registration/Common/include/itkMeanReciprocalSquareDifferencePointSetToImageMetric.hxx

@@ -147,7 +147,7 @@ MeanReciprocalSquareDifferencePointSetToImageMetric<TFixedPointSet, TMovingImage
       using MovingImageContinuousIndexType = ContinuousIndex<CoordinateType, MovingImageType::ImageDimension>;
 
       const MovingImageContinuousIndexType tempIndex =
-        this->m_MovingImage->template TransformPhysicalPointToContinuousIndex<CoordinateType>(transformedPoint);
+        this->m_MovingImage->TransformPhysicalPointToContinuousIndex(transformedPoint);
 
       typename MovingImageType::IndexType mappedIndex;
       mappedIndex.CopyWithRound(tempIndex);
@@ -246,7 +246,7 @@ MeanReciprocalSquareDifferencePointSetToImageMetric<TFixedPointSet, TMovingImage
       using MovingImageContinuousIndexType = ContinuousIndex<CoordinateType, MovingImageType::ImageDimension>;
 
       const MovingImageContinuousIndexType tempIndex =
-        this->m_MovingImage->template TransformPhysicalPointToContinuousIndex<CoordinateType>(transformedPoint);
+        this->m_MovingImage->TransformPhysicalPointToContinuousIndex(transformedPoint);
 
       typename MovingImageType::IndexType mappedIndex;
       mappedIndex.CopyWithRound(tempIndex);

Modules/Registration/Common/include/itkMeanSquaresPointSetToImageMetric.hxx

@@ -140,7 +140,7 @@ MeanSquaresPointSetToImageMetric<TFixedPointSet, TMovingImage>::GetDerivative(
       using MovingImageContinuousIndexType = ContinuousIndex<CoordinateType, MovingImageType::ImageDimension>;
 
       const MovingImageContinuousIndexType tempIndex =
-        this->m_MovingImage->template TransformPhysicalPointToContinuousIndex<CoordinateType>(transformedPoint);
+        this->m_MovingImage->TransformPhysicalPointToContinuousIndex(transformedPoint);
 
       typename MovingImageType::IndexType mappedIndex;
       mappedIndex.CopyWithRound(tempIndex);
@@ -240,7 +240,7 @@ MeanSquaresPointSetToImageMetric<TFixedPointSet, TMovingImage>::GetValueAndDeriv
       using MovingImageContinuousIndexType = ContinuousIndex<CoordinateType, MovingImageType::ImageDimension>;
 
       const MovingImageContinuousIndexType tempIndex =
-        this->m_MovingImage->template TransformPhysicalPointToContinuousIndex<CoordinateType>(transformedPoint);
+        this->m_MovingImage->TransformPhysicalPointToContinuousIndex(transformedPoint);
 
       typename MovingImageType::IndexType mappedIndex;
       mappedIndex.CopyWithRound(tempIndex);

Modules/Registration/Common/include/itkNormalizedCorrelationImageToImageMetric.hxx

@@ -241,7 +241,7 @@ NormalizedCorrelationImageToImageMetric<TFixedImage, TMovingImage>::GetDerivativ
       using MovingImageContinuousIndexType = ContinuousIndex<CoordinateType, MovingImageType::ImageDimension>;
 
       const MovingImageContinuousIndexType tempIndex =
-        this->m_MovingImage->template TransformPhysicalPointToContinuousIndex<CoordinateType>(transformedPoint);
+        this->m_MovingImage->TransformPhysicalPointToContinuousIndex(transformedPoint);
 
       typename MovingImageType::IndexType mappedIndex;
       mappedIndex.CopyWithRound(tempIndex);
@@ -425,7 +425,7 @@ NormalizedCorrelationImageToImageMetric<TFixedImage, TMovingImage>::GetValueAndD
       using MovingImageContinuousIndexType = ContinuousIndex<CoordinateType, MovingImageType::ImageDimension>;
 
       const MovingImageContinuousIndexType tempIndex =
-        this->m_MovingImage->template TransformPhysicalPointToContinuousIndex<CoordinateType>(transformedPoint);
+        this->m_MovingImage->TransformPhysicalPointToContinuousIndex(transformedPoint);
 
       typename MovingImageType::IndexType mappedIndex;
       mappedIndex.CopyWithRound(tempIndex);

Modules/Registration/Common/include/itkNormalizedCorrelationPointSetToImageMetric.hxx

@@ -184,7 +184,7 @@ NormalizedCorrelationPointSetToImageMetric<TFixedPointSet, TMovingImage>::GetDer
       using MovingImageContinuousIndexType = ContinuousIndex<CoordinateType, MovingImageType::ImageDimension>;
 
       const MovingImageContinuousIndexType tempIndex =
-        this->GetMovingImage()->template TransformPhysicalPointToContinuousIndex<CoordinateType>(transformedPoint);
+        this->GetMovingImage()->TransformPhysicalPointToContinuousIndex(transformedPoint);
 
       typename MovingImageType::IndexType mappedIndex;
       mappedIndex.CopyWithRound(tempIndex);
@@ -327,7 +327,7 @@ NormalizedCorrelationPointSetToImageMetric<TFixedPointSet, TMovingImage>::GetVal
       using MovingImageContinuousIndexType = ContinuousIndex<CoordinateType, MovingImageType::ImageDimension>;
 
       const MovingImageContinuousIndexType tempIndex =
-        this->GetMovingImage()->template TransformPhysicalPointToContinuousIndex<CoordinateType>(transformedPoint);
+        this->GetMovingImage()->TransformPhysicalPointToContinuousIndex(transformedPoint);
 
       typename MovingImageType::IndexType mappedIndex;
       mappedIndex.CopyWithRound(tempIndex);

Modules/Segmentation/SuperPixel/include/itkSLICImageFilter.hxx

@@ -148,8 +148,7 @@ SLICImageFilter<TInputImage, TOutputImage, TDistancePixel>::BeforeThreadedGenera
       const IndexType &                  idx = it.ComputeIndex();
       typename InputImageType::PointType pt;
       shrunkImage->TransformIndexToPhysicalPoint(idx, pt);
-      const ContinuousIndexType cidx =
-        inputImage->template TransformPhysicalPointToContinuousIndex<typename PointType::ValueType>(pt);
+      const ContinuousIndexType cidx = inputImage->TransformPhysicalPointToContinuousIndex(pt);
       for (unsigned int i = 0; i < ImageDimension; ++i)
       {
         cluster[numberOfComponents + i] = cidx[i];

Testing/ContinuousIntegration/AzurePipelinesLinuxPython.yml

@@ -130,6 +130,30 @@ jobs:
         CTEST_OUTPUT_ON_FAILURE: 1
         CCACHE_MAXSIZE: 8G
 
+    - bash: |
+        set -x
+        # Shrink the local ccache and prune the build tree before the
+        # implicit post-job 'Cache@2' uploader tars CCACHE_DIR. Issue:
+        # the post-job tar fails ENOSPC when the runner's writable disk
+        # is too full to hold the temporary archive (Azure DevOps
+        # ITK.Linux.Python builds 14748 / 14751 both hit
+        #   tar: Wrote only 4096 of 10240 bytes
+        #   tar: Error is not recoverable
+        # at 95-96% disk usage). Drop ccache items > 5 days old, force
+        # the local store under 6.5G with -c, then 'ninja clean' the
+        # build tree to free the .o files that are no longer needed
+        # after the build/test phase has reported.
+        df -h /
+        ccache --show-stats
+        ccache --evict-older-than 5d
+        ccache --max-size 6.5G
+        ccache -c
+        ccache --show-stats
+        ninja -C $(Build.SourcesDirectory)-build clean || true
+        df -h /
+      condition: always()
+      displayName: 'Free disk before post-job ccache upload'
+
     - bash: ccache --show-stats
       condition: always()
       displayName: 'ccache stats'