ENH: Ingest ITKBoneEnhancement into Modules/Filtering/BoneEnhancement#6272
Merged
hjmjohnson merged 176 commits intoMay 20, 2026
Merged
Conversation
greater than to make concept checking easy, use Math::abs instead of vnl_math_abs
formatting in failed test
variable. Instead, implement the pure virtual function GetEigenValueOrder()
…entImageF ilter.h
exceptions instead of returning empty sigma arrays
MultiScaleHessianEnhancementImageFilter
Enh/base - Initial framework written
…ed lower case t typo
KrcahEigentoScalarParameterEstimationImageFilter
MaximumAbsoluteValueImageFilter
MultiScaleHessianEnhancementImageFilter
…ncorrect when pushed remote
|
Errors:
|
hjmjohnson
added a commit
to hjmjohnson/ITK
that referenced
this pull request
May 14, 2026
The if(NOT ITK_SOURCE_DIR) branch (find_package(ITK) + include(ITKModuleExternal)) only executes when building the module standalone outside ITK. In-tree builds always take the itk_module_impl() else branch. Drop the dead branch following the cleanup pattern from InsightSoftwareConsortium#6272/InsightSoftwareConsortium#6279.
hjmjohnson
added a commit
to hjmjohnson/ITK
that referenced
this pull request
May 14, 2026
The if(NOT ITK_SOURCE_DIR) branch (find_package(ITK) + include(ITKModuleExternal)) only executes when building the module standalone outside ITK. In-tree builds always take the itk_module_impl() else branch. Drop the dead branch following the cleanup pattern from InsightSoftwareConsortium#6272/InsightSoftwareConsortium#6279.
Member
Author
|
@greptileai review |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
hjmjohnson
added a commit
to hjmjohnson/ITK
that referenced
this pull request
May 17, 2026
The if(NOT ITK_SOURCE_DIR) branch (find_package(ITK) + include(ITKModuleExternal)) only executes when building the module standalone outside ITK. In-tree builds always take the itk_module_impl() else branch. Drop the dead branch following the cleanup pattern from InsightSoftwareConsortium#6272/InsightSoftwareConsortium#6279.
hjmjohnson
added a commit
to hjmjohnson/ITK
that referenced
this pull request
May 19, 2026
The if(NOT ITK_SOURCE_DIR) branch (find_package(ITK) + include(ITKModuleExternal)) only executes when building the module standalone outside ITK. In-tree builds always take the itk_module_impl() else branch. Drop the dead branch following the cleanup pattern from InsightSoftwareConsortium#6272/InsightSoftwareConsortium#6279.
hjmjohnson
added a commit
to hjmjohnson/ITK
that referenced
this pull request
May 19, 2026
The if(NOT ITK_SOURCE_DIR) branch (find_package(ITK) + include(ITKModuleExternal)) only executes when building the module standalone outside ITK. In-tree builds always take the itk_module_impl() else branch. Drop the dead branch following the cleanup pattern from InsightSoftwareConsortium#6272/InsightSoftwareConsortium#6279.
Brings BoneEnhancement from a configure-time remote fetch into the ITK source tree at Modules/Filtering/BoneEnhancement/ using the v4 ingestion pipeline (whitelist filter-repo + per-commit clang-format + black + commit-prefix sanitization). Upstream repo: https://github.com/InsightSoftwareConsortium/ITKBoneEnhancement.git Upstream tip: 479604dbc883e25a2147c436237b9ac35fc77c2c Ingest date: 2026-05-14 Whitelist: default.list Per-commit transforms applied across all 163 commits: - filter-repo --paths-from-file (whitelist) - filter-repo --to-subdirectory-filter Modules/Filtering/BoneEnhancement - clang-format -style=file (ITK main's .clang-format) for *.cxx/.h/.hxx/... - black for *.py - heuristic ITK prefix added to commit subjects without one Merge topology preserved: 39 -> 24 merge(s). Primary author: Bryce Besler <babesler@ucalgary.ca> Co-authored-by: Bryce Besler <Besler@users.noreply.github.com> Co-authored-by: Dzenan Zukic <dzenan.zukic@kitware.com> Co-authored-by: Dženan Zukić <dzenan.zukic@kitware.com> Co-authored-by: Hans J. Johnson <hans-johnson@uiowa.edu> Co-authored-by: Hans Johnson <hans-johnson@uiowa.edu> Co-authored-by: Jon Haitz Legarreta Gorroño <jon.haitz.legarreta@gmail.com> Co-authored-by: Mathew Seng <mathewseng@gmail.com> Co-authored-by: Matt McCormick <matt.mccormick@kitware.com> Co-authored-by: Matt McCormick <matt@mmmccormick.com> Co-authored-by: Pablo Hernandez-Cerdan <pablo.hernandez.cerdan@outlook.com> Co-authored-by: Tom Birdsong <tom.birdsong@kitware.com>
BoneEnhancement has been ingested into Modules/Filtering/BoneEnhancement; drop the remote-module stub and enable Module_BoneEnhancement in the pixi configure-ci task so CI exercises the in-tree module.
The mask was set twice on m_EigenToMeasureParameterEstimationFilter instead of being forwarded to m_EigenToMeasureImageFilter, so the per-pixel measure ran unmasked across the full image.
The if(NOT ITK_SOURCE_DIR) branch (find_package(ITK) + include(ITKModuleExternal)) only executes when building the module standalone outside ITK. In-tree builds always take the itk_module_impl() else branch. Drop the dead branch following the cleanup pattern from InsightSoftwareConsortium#6272/InsightSoftwareConsortium#6279.
Use a domain-specific description derived from the upstream README rather than the generic 'Module ingested from upstream.' placeholder.
generateResponseAtScale returned the EigenToMeasure filter's output object directly. The next scale's Update() reuses that same buffer, so the scale-0 response aliased the scale-1 response and the multi-scale maximum silently dropped the scale-0 contribution. DisconnectPipeline() on the returned image gives each scale its own buffer.
hjmjohnson
force-pushed
the
ingest-BoneEnhancement
branch
from
874a372 to
b14825d
Compare
# Conflicts: # pyproject.toml
Member
Author
|
/azp run ITK.Linux.Python |
Member
Author
|
/azp run ITK.macOS.Python |
hjmjohnson
added a commit
to hjmjohnson/ITK
that referenced
this pull request
May 20, 2026
The if(NOT ITK_SOURCE_DIR) branch (find_package(ITK) + include(ITKModuleExternal)) only executes when building the module standalone outside ITK. In-tree builds always take the itk_module_impl() else branch. Drop the dead branch following the cleanup pattern from InsightSoftwareConsortium#6272/InsightSoftwareConsortium#6279.
dzenanz
approved these changes
May 20, 2026
hjmjohnson
merged commit 01c60b8
into
InsightSoftwareConsortium:main
18 of 19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ingest the ITKBoneEnhancement remote module into
Modules/Filtering/BoneEnhancement(group: Filtering). Source upstream:InsightSoftwareConsortium/ITKBoneEnhancement. Tracking issue: #6160.Ingest stats
Utilities/Maintenance/RemoteModuleIngest/INGESTION_STRATEGY.md)Modules/Filtering/BoneEnhancement/: 47a765aa2b13ec4653471c0c1bcc8e96cd70d5ffc3External-data fixtures
CID / .sha512 content-links present in this ingest:
(none -- module has no external-data fixtures)
If any fixtures resolve via ITKTestingData, that repo must contain the matching content-link before this PR can merge cleanly.
Follow-on commits (on top of the unrelated-histories merge)