Skip to content

ENH: Add wrapping for RieszRotationMatrix#93

Merged
phcerdan merged 1 commit into
masterfrom
add_wrap_riesz_rotation_matrix
Oct 24, 2018
Merged

ENH: Add wrapping for RieszRotationMatrix#93
phcerdan merged 1 commit into
masterfrom
add_wrap_riesz_rotation_matrix

Conversation

@phcerdan
Copy link
Copy Markdown
Collaborator

Wrap only double, as base class VariableSizeMatrix

Supersedes and closes #59

Co-authored-by: Jon Haitz Legarreta Gorroñojon.haitz.legarreta@gmail.com
Co-authored-by: Matt McCormickmatt.mccormick@kitware.com

@phcerdan phcerdan force-pushed the add_wrap_riesz_rotation_matrix branch from 75bf6c5 to f87b261 Compare October 22, 2018 00:32
Wrap only double, as base class VariableSizeMatrix

Supersedes and closes #59

Co-authored-by: Jon Haitz Legarreta Gorroño<jon.haitz.legarreta@gmail.com>
Co-authored-by: Matt McCormick<matt.mccormick@kitware.com>
Copy link
Copy Markdown
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice work, @phcerdan !

@jhlegarreta
Copy link
Copy Markdown
Member

🎉 Thanks @phcerdan !

@jhlegarreta
Copy link
Copy Markdown
Member

BTW, is the POINTER argument missing in the itk_wrap_class?

@phcerdan
Copy link
Copy Markdown
Collaborator Author

Thanks!

BTW, is the POINTER argument missing in the itk_wrap_class?

I don't think so, it is a matrix ( I followed the file for the current wrapping of VariableSizeMatrix which is its base class )

@jhlegarreta
Copy link
Copy Markdown
Member

👍

@phcerdan phcerdan merged commit e5f217c into master Oct 24, 2018
@hjmjohnson hjmjohnson deleted the add_wrap_riesz_rotation_matrix branch November 4, 2018 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants