Skip to content

ENH: Bump ITK to 5.3.0#191

Merged
thewtex merged 1 commit intoInsightSoftwareConsortium:masterfrom
thewtex:itk-5.3.0
Nov 24, 2022
Merged

ENH: Bump ITK to 5.3.0#191
thewtex merged 1 commit intoInsightSoftwareConsortium:masterfrom
thewtex:itk-5.3.0

Conversation

@thewtex
Copy link
Copy Markdown
Member

@thewtex thewtex commented Nov 24, 2022

No description provided.

@github-actions github-actions bot added the type:Enhancement Improvement of existing methods or implementation label Nov 24, 2022
jhlegarreta
jhlegarreta previously approved these changes Nov 24, 2022
Copy link
Copy Markdown
Member

@jhlegarreta jhlegarreta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd have loved to see the commit subject in the message body to match the ITK commit recommendations.

dzenanz
dzenanz previously approved these changes Nov 24, 2022
@thewtex
Copy link
Copy Markdown
Member Author

thewtex commented Nov 24, 2022

I am not sure that a commit message body is needed in this case. @jhlegarreta what do you recommend?

@jhlegarreta
Copy link
Copy Markdown
Member

I am not sure that a commit message body is needed in this case. @jhlegarreta what do you recommend?

Sorry Matt, I prefer to at least copy the subject rather than leaving the body empty following what I said in the ITK PR. As it was the case there, the subject is self-speaking, so copying it is enough IMO. Thanks.

Bump ITK to 5.3.0
@thewtex thewtex dismissed stale reviews from dzenanz and jhlegarreta via 83a3e23 November 24, 2022 16:28
@thewtex thewtex merged commit 905c9bb into InsightSoftwareConsortium:master Nov 24, 2022
@thewtex thewtex deleted the itk-5.3.0 branch November 24, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:Enhancement Improvement of existing methods or implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants