Description
After fixing a number of failing tests in the recent weeks, I came across some inconsistencies in the baseline test cases. Essentially, all of the baseline comparisons that compare an image without the name OutputBaseline, are incorrectly comparing results. An example can be found in the AddNoiseToBinaryImageTestBaselineComparison, which produces:
/Users/mseng_l/ITKExamples-build/bin/ImageCompareCommand "--test-image"
"/Users/mseng_l/ITKExamples-build/src/Core/Common/AddNoiseToBinaryImage/AddNoiseToBinaryImage.png" "--baseline-image"
"/Users/mseng_l/ITKExamples-build/src/Core/Common/AddNoiseToBinaryImage/AddNoiseToBinaryImage.png"
As shown above, the baseline comparison is not comparing the example's output to the baseline image, but rather the baseline image to itself, which will always yield a passing result.
This and many others will likely require one of the following changes:
Description
After fixing a number of failing tests in the recent weeks, I came across some inconsistencies in the baseline test cases. Essentially, all of the baseline comparisons that compare an image without the name
OutputBaseline, are incorrectly comparing results. An example can be found in theAddNoiseToBinaryImageTestBaselineComparison, which produces:As shown above, the baseline comparison is not comparing the example's output to the baseline image, but rather the baseline image to itself, which will always yield a passing result.
This and many others will likely require one of the following changes:
AddNoiseToBinaryImagedue toMersenneTwisterRandomVariateGenerator)OutputBaselinefor examples that consistently produce and save their outputImageFileWriterfor examples that do not save their output. Subsequently update the baseline comparison for that example, upload the image toGirderand finally update theDocumentation.rst