-
Notifications
You must be signed in to change notification settings - Fork 69
Increase consistency in src/Developer files #318
Copy link
Copy link
Open
Labels
Good first issueA good issue for community members new to contributingA good issue for community members new to contributingtype:BugInconsistencies or issues which will cause an incorrect result under some or all circumstancesInconsistencies or issues which will cause an incorrect result under some or all circumstancestype:StyleStyle changes: no logic impact (indentation, comments, naming)Style changes: no logic impact (indentation, comments, naming)
Metadata
Metadata
Assignees
Labels
Good first issueA good issue for community members new to contributingA good issue for community members new to contributingtype:BugInconsistencies or issues which will cause an incorrect result under some or all circumstancesInconsistencies or issues which will cause an incorrect result under some or all circumstancestype:StyleStyle changes: no logic impact (indentation, comments, naming)Style changes: no logic impact (indentation, comments, naming)
Type
Fields
Give feedbackNo fields configured for issues without a type.
The files in src/Developer seem to hold some inconsistencies:
ImageFilterX.*andImageFilterY.*files should probably be renamed toImageFilterXandImageFilterY. They currently define a class namesImageFilter, which is also defined in theImageFilter.*file.itk*. There are actually some inconsistencies in classes with supposedly similar patterns, e.g.itkImageFilterMultipleInputs.*vsImageFilterMultipleOutputs.*` -not sure if intended). This will need to be accompanied with the appropriate changes to the include guards.It is probably a good idea to know if these were intended, and if yes, make it clear the reason, as it does not seem intuitive.
Maybe the notices
Warning Fix Errors Example contains errors needed to be fixed for proper output.that are visible in the concerned pages raises from these observations, e.g.https://itk.org/ITKExamples/src/Core/Common/ProduceImageProgrammatically/Documentation.html
Following #316 (comment).