Skip to content

BUG: Fixes for HTML documentation#325

Merged
tbirdso merged 1 commit into
InsightSoftwareConsortium:masterfrom
tbirdso:fix-docs
Mar 10, 2022
Merged

BUG: Fixes for HTML documentation#325
tbirdso merged 1 commit into
InsightSoftwareConsortium:masterfrom
tbirdso:fix-docs

Conversation

@tbirdso
Copy link
Copy Markdown
Contributor

@tbirdso tbirdso commented Mar 9, 2022 •
edited
Loading

Changes:

  • Update DoxygenTAG.gz link to point to updated source at itk.org
  • Fix RGB image init value in CropImageBySpecifyingRegion2 example

Resolves #324.

@github-actions github-actions Bot added area:Filtering Issues affecting the Filtering module language:C++ Changes to C++ examples type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots labels Mar 9, 2022
@tbirdso
Copy link
Copy Markdown
Contributor Author

tbirdso commented Mar 9, 2022

Note that I have entered this as a draft while awaiting an internal resolution on the correct path for getting the updated tag archive. Once that is resolved I will mark as ready.

@tbirdso
BUG: Fixes for HTML documentation
0f025e3 
- Update DoxygenTAG.gz link to point to itk.org
- Fix RGB image init value in `CropImageBySpecifyingRegion2` example
@tbirdso tbirdso marked this pull request as ready for review March 9, 2022 18:06
@tbirdso
Copy link
Copy Markdown
Contributor Author

tbirdso commented Mar 9, 2022

Amended to set definitive tag path at itk.org. Ready for review.

thewtex
thewtex approved these changes Mar 9, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @tbirdso !

@tbirdso
Copy link
Copy Markdown
Contributor Author

tbirdso commented Mar 10, 2022

Looks like CI failed due to warnings in .rst files unrelated to changes in this PR.

CDash results

WARNING: Duplicate C++ declaration, also defined at src/Bridge/VtkGlue/ConvertAnRGBitkImageTovtkImageData/Documentation:129
...

The warnings do not prevent docs from being built, though they may prevent CI from publishing docs. I am going to move forward with the merge here and investigate warnings in a subsequent PR.

@tbirdso tbirdso merged commit 7c7f794 into InsightSoftwareConsortium:master Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thewtex thewtex thewtex approved these changes

@dzenanz dzenanz dzenanz approved these changes

@hjmjohnson hjmjohnson Awaiting requested review from hjmjohnson

Assignees

No one assigned

Labels

area:Filtering Issues affecting the Filtering module language:C++ Changes to C++ examples type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix documentation CI failure

3 participants

@tbirdso @thewtex @dzenanz