Don't require whitespace right after match#628
Merged
stroxler merged 1 commit intoJan 24, 2022
Conversation
facebook-github-bot
added
the
CLA Signed
Codecov Report
@@ Coverage Diff @@
## main #628 +/- ##
=======================================
Coverage 94.78% 94.79%
=======================================
Files 245 245
Lines 25256 25254 -2
=======================================
- Hits 23940 23939 -1
+ Misses 1316 1315 -1
Continue to review full report at Codecov.
|
stroxler
approved these changes
Jan 24, 2022
Contributor
stroxler
left a comment
stroxler
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for catching the bug!
This was referenced Jan 28, 2022
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #627. This check seems like preventing something that is allowed in the regular Python.
Test Plan
Added a test which didn't work before this patch.