[WIP] processorfuzz - #42
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
clippy found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
| scounteren: u32, | ||
| } | ||
|
|
||
| impl Comb { |
Check warning
Code scanning / clippy
associated function `new` is never used
| } | ||
|
|
||
| impl Comb { | ||
| fn new(mstatus: u32, frm: u32, fflags: u32, mcause: u32, scause: u32, medeleg: u32, mcounteren: u32, scounteren: u32) -> Self { |
Check warning
Code scanning / clippy
this function has too many arguments (8/7)
| } | ||
|
|
||
| impl Comb { | ||
| fn new(mstatus: u32, frm: u32, fflags: u32, mcause: u32, scause: u32, medeleg: u32, mcounteren: u32, scounteren: u32) -> Self { |
Check warning
Code scanning / clippy
associated function `new` is never used
|
|
||
| // search for new transitions considering all available CSR, requires Spike specific | ||
| // compilation flag | ||
| if self.all_csr.is_some() && self.all_csr.unwrap() == true { |
Check warning
Code scanning / clippy
equality checks against true are unnecessary
| let instr_t = trace_line.inst; | ||
|
|
||
| if !self.comb_priv.contains(&(instr_t, comb_pr_p, comb_pr).clone()) && comb_pr_p != comb_pr { | ||
| self.comb_priv.push((instr_t, comb_pr_p, comb_pr).clone()); |
Check warning
Code scanning / clippy
using `clone` on type `(u64, CombPr, CombPr)` which implements the `Copy` trait
| pub fn new(pc: u64, inst: u64, ops: Vec<OpLog>, csr: Option<CSRLog>) -> Self { | ||
| Self{ | ||
| pc:pc, | ||
| inst:inst, |
Check warning
Code scanning / clippy
redundant field names in struct initialization
| Self{ | ||
| pc:pc, | ||
| inst:inst, | ||
| ops:ops, |
Check warning
Code scanning / clippy
redundant field names in struct initialization
| pc:pc, | ||
| inst:inst, | ||
| ops:ops, | ||
| csr:csr, |
Check warning
Code scanning / clippy
redundant field names in struct initialization
| OpLog::RegOp(RegOp{op_type: OpType::Read, name: caps[3].to_string(), value: u64::from_str_radix(&caps[4], 16).unwrap()}) | ||
| ]; | ||
|
|
||
| if caps.get(5) != None && &caps[6] == "mem" { |
Check warning
Code scanning / clippy
binary comparison to literal `Option::None`
|
|
||
| if caps.get(5) != None && &caps[6] == "mem" { | ||
| ops.push(OpLog::MemOp(MemOp{op_type: OpType::Read, address: u64::from_str_radix(&caps[7], 16).unwrap(), value: u64::from_str_radix(&caps[4], 16).unwrap()})); | ||
| } else if caps.get(5) != None { |
Check warning
Code scanning / clippy
binary comparison to literal `Option::None`
2 participants
No description provided.