Depend on the source headers directly

[ZzEeKkAa]

Update CMake configuration and headers to use better target dependencies. It will unblock incremental compilation and flexible dependency management.

• Have you provided a meaningful PR description?
• Have you added a test, reproducer or referred to an issue with a reproducer?
• Have you tested your changes locally for CPU and GPU devices?
• Have you made sure that new changes do not introduce compiler warnings?
• Have you checked performance impact of proposed changes?
• If this PR is a work in progress, are you opening the PR as a draft?

[github-actions]

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

[github-actions]

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_108 ran successfully.
Passed: 906
Failed: 0
Skipped: 94

[github-actions]

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_108 ran successfully.
Passed: 906
Failed: 0
Skipped: 94

[github-actions]

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_108 ran successfully.
Passed: 906
Failed: 0
Skipped: 94

[github-actions]

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_108 ran successfully.
Passed: 906
Failed: 0
Skipped: 94

[github-actions]

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_109 ran successfully.
Passed: 906
Failed: 0
Skipped: 94

[github-actions]

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_113 ran successfully.
Passed: 905
Failed: 1
Skipped: 94

[github-actions]

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_114 ran successfully.
Passed: 905
Failed: 1
Skipped: 94

[github-actions]

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_115 ran successfully.
Passed: 905
Failed: 1
Skipped: 94

[coveralls]

coverage: 87.832%. remained the same
when pulling 1757afe on feature/include_from_source
into 80f4f30 on master.

[github-actions]

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_123 ran successfully.
Passed: 905
Failed: 1
Skipped: 94

[oleksandr-pavlyk]

Increase in coverage is due to disappearence of Cython files from coverage.

This issue must resolved before the PR can be merged.

We need to understand whether the regression is due to changes of build script or due to upgrade from Cython 3.0.8 to Cuthon 3.0.9 that happened since the PR was first opened.

[oleksandr-pavlyk]

gh-1586 does not exhibit changes in coverage metrics despite also using Cython 3.0.9.

I also checked that C++ code generated by Cython did not materially change between versions.

Thus the change is caused by build system reorg.

[oleksandr-pavlyk]

This message emitted while processing .coverage database points to a problem:

Source file is not python /home/runner/work/dpctl/dpctl/dpctl/_diagnostics.pyx

[ZzEeKkAa]

May it be because we don't copy headers/cpp files of cython to source directory and they are always in build directory now?

[oleksandr-pavlyk]

May it be because we don't copy headers/cpp files of cython to source directory and they are always in build directory now?

Yes, indeed. See http://blog.behnel.de/posts/coverage-analysis-for-cython-modules.html

I have pushed changes to copy CXX files into layout for coverage builds.

[github-actions]

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_127 ran successfully.
Passed: 906
Failed: 0
Skipped: 94

[github-actions]

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_128 ran successfully.
Passed: 906
Failed: 0
Skipped: 94

[oleksandr-pavlyk]

Thank you for getting this done @ZzEeKkAa ! Looks good to me now!

[oleksandr-pavlyk]

Testing clean building with and without use of lld, using

/usr/bin/time -f "%P %M %E" python scripts/build_locally.py --verbose

outputs are, on my WSL machine,

with lld
641% 3953024 20:24.33

with default linker
632% 4048804 20:59.47

[ndgrigorian]

I have also tested building this branch locally and it worked fine, so LGTM

[oleksandr-pavlyk]

I have checked locally that dpnp build continues working as expected.

[antonwolfy]

I can also confirm that dpnp build works with that PR without any issue.