Open
Conversation
Member
This was intentional to be closer to the WE adapters. |
Author
Oops, thought it was a mistake, I renamed it back to |
SirYwell
reviewed
Apr 9, 2026
| ? PrimaryLevelData.SpecialWorldProperty.DEBUG | ||
| : PrimaryLevelData.SpecialWorldProperty.NONE; | ||
| PrimaryLevelData newWorldData = new PrimaryLevelData(newWorldSettings, newOpts, specialWorldProperty, Lifecycle.stable()); | ||
| PaperWorldLoader.LoadedWorldData loadedWorldData = new PaperWorldLoader.LoadedWorldData( |
Member
There was a problem hiding this comment.
This only works on Paper I guess? Is there an easy way to make it work on Spigot? Otherwise it might make sense to fail regeneration more gracefully on Spigot.
Author
There was a problem hiding this comment.
Indeed, paperweight overrides the only constructor on ServerLevel, requiring an extra argument PaperWorldLoader.LoadedWorldData
I added a throw exception on regenerations if the server is not Paper, let me know if it's what you had in mind!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Made it compile on 26.1
Renamed adapter
26.1to26_1(to keep the same syntax)Removed reobf for new Minecraft versions (26.1 and above)
Submitter Checklist
@since TODO.