fix: allow 0-width stroke width and 0-percent fill-opacity#73
Merged
NotMyFault merged 2 commits intomainfrom Feb 4, 2022
Merged
fix: allow 0-width stroke width and 0-percent fill-opacity#73NotMyFault merged 2 commits intomainfrom
NotMyFault merged 2 commits intomainfrom
Conversation
Member
Author
|
Regression I found out: Now the area is not clickable anymore, just the border, if the opacity is 0 no |
NotMyFault
reviewed
Jan 26, 2022
Collaborator
NotMyFault
left a comment
There was a problem hiding this comment.
My experience with Dynmap is limited. Is that something we can resolve on our end?
Member
Author
I've searched through dynmaps source as well, but I don't know either. I've created a separated issue as a feature request in dynmaps repo for that: webbukkit/dynmap#3637 |
Member
Author
|
@NotMyFault Found a workaround by setting the color to #FF000000 when the opacity is set to 0. The opacity is then set back to 1 and an 0-alpha channel is passed to the fill color. therefor the fill is still being added to the dom, but it's invisible. |
Collaborator
|
/rebase |
1eb11dc to
8768008
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Based on an issue on discord

Description
Now a 0-width stroke width and 0-percent fill-opacity is possible + code reformat
Submitter Checklist
Maintainer checklist
Before the changes are marked as
Ready for merge: