This repository was archived by the owner on Apr 17, 2026. It is now read-only.
Include blobs in the fetcher response.#8
Open
daniel-intellegens wants to merge 1 commit into
Open
Conversation
aidan-keay
reviewed
Mar 10, 2022
| const response = await fetch(url, init) | ||
|
|
||
| const data = await getResponseData(response) | ||
| const data = await getResponseData(response.clone()) |
There was a problem hiding this comment.
Will this still fetch the non-blob version even if the we subscribe to the blob stream? I don't see a flag to disable the non-blob fetch.
Author
There was a problem hiding this comment.
Both the blob and JSON response should be included in the response and either could be used.
There was a problem hiding this comment.
I thought we wanted to disable the JSON response since it would crash the frontend (memory overload)?
There was a problem hiding this comment.
Maybe @jpcano can confirm, that was my understanding at least.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEV-2603
Included the blob data in the fetch response also updated the types.