You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is the beginning of a proposal/spec for supporting JSON. The goal was to reveal a pattern that can be applied to other Model and QueryBuilder methods. I'd like to get opinions before I commit to the remaining query methods.
Context
JSON support requires some sort of schema because it uses a TEXT column type, but requires additional context/knowledge that the column should be treated as JSON. With this in mind, the QueryBuilder has been updated to accept a columns? property in the options.
Changes to note
adds a json boolean to the ModelColumn interface.
adds an optional columns config to the GenerateQueryOptions
updates the query builder for INSERT and INSERT_OR_REPLACE to check for a column config and give special treatment if column.json is truthy.
updates the Model.InsertOne method to pass columns in the options.
updates QueryBuilder tests to show that queries are correctly formed.
I've run the code in wrangler dev to make sure it works in "production".
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Thanks for this! I definitely like the idea of introducing JSON support to the library. I'm curious to hear your ideas as to how this would be done for Updating and Selecting - what if a user wants to query based on something within one of the columns?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This is the beginning of a proposal/spec for supporting JSON. The goal was to reveal a pattern that can be applied to other Model and QueryBuilder methods. I'd like to get opinions before I commit to the remaining query methods.
Context
JSON support requires some sort of schema because it uses a
TEXTcolumn type, but requires additional context/knowledge that the column should be treated as JSON. With this in mind, the QueryBuilder has been updated to accept acolumns?property in the options.Changes to note
jsonboolean to theModelColumninterface.columnsconfig to theGenerateQueryOptionsINSERTandINSERT_OR_REPLACEto check for a column config and give special treatment ifcolumn.jsonis truthy.Model.InsertOnemethod to passcolumnsin the options.I've run the code in wrangler dev to make sure it works in "production".