[ARCH]Add SiameseNorm and DepthAttention architecture - #19
Open
franksfc wants to merge 4 commits into
Open
Conversation
4 tasks
Collaborator
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Architecture Proposal
#2
Implementation Details
This PR implements SiameseNorm + Depth-Attention on top of the OLMo 3 decoder architecture and includes the reproducible Ascend/MindSpeed training pipeline used for the current 1B artifacts.
Modified components
baseandsiamese_depthOLMo 3 model variants.[SWA, SWA, SWA, Full]attention pattern.arch/SiameseNorm-DepthAttention.Key implementation details
l, the Post-Norm-like stream receives the depth-scaled updateΔ / sqrt(2l), while the Pre-Norm-like stream receives the full updateΔ.Compatibility considerations
Current deviations and scope
Experimental Validation
Research Question 1 — Does the implementation preserve OLMo 3 training, checkpoint, and long-context inference semantics?
Hypothesis: SiameseNorm and Depth-Attention can be integrated without breaking the four-stage OLMo 3 pipeline, checkpoint transitions, SWA/Full-Attention behavior, or 65K inference.
Results & Analysis:
The modified 1B model completed and published the following artifacts:
Findings: The current evidence supports implementation correctness and end-to-end operability at the 1B scale.
Research Question 2 — Does SiameseNorm + Depth-Attention improve model quality?
Hypothesis: At matched model size, data order, token count, optimizer, learning-rate schedule, batch size, random seed, and evaluation protocol, the modified architecture will improve training loss and downstream evaluation metrics without introducing instability.
Results & Analysis:
Preliminary evaluation shows a positive aggregate result. The current OLMo 3 1B Instruct-SFT checkpoint reaches a macro average of 36.9, compared with 34.2 for the published OLMo 2 1B pure-SFT reference, an improvement of +2.7 points across the eight reported benchmarks.
The strongest preliminary gains are observed on IFEval (+19.6), BBH (+6.1), and MMLU (+4.2). The modified model improves on four of the eight individual benchmarks and raises the overall macro average despite regressions on several tasks.
This table is an early external-reference comparison, not the final controlled baseline experiment. The matched OLMo 3 1B baseline is still training, and final matched-token loss curves and downstream results will be added when that run finishes.
Findings: Preliminary results indicate a meaningful aggregate improvement, with especially strong gains in instruction following and selected reasoning/knowledge benchmarks. The final effectiveness conclusion remains pending until the matched OLMo 3 baseline and complete evaluation are available.
Research Question 3 — Does the result generalize beyond 1B?
Hypothesis: The combined architecture remains stable and beneficial at larger model scales.
Results & Analysis:
No completed 3B or 7B/8B matched validation is included yet.
Findings: Pending. This PR should remain in draft until the target model scales are reconciled and the required experiments are complete.
Archive
Reviewer Assessment (for repo reviewers)
Draft status is recommended. The implementation, 1B four-stage artifact path, and preliminary positive evaluation are available for review. The controlled matched-baseline experiment and multi-scale generalization are still in progress and should be completed before the final merge-readiness assessment.
Merge Checklist:
in-progressArchitecture Proposal issue (#43).