Skip to content

fix free cache in MPEngine branch#3670

Merged
lvhan028 merged 48 commits intoInternLM:mainfrom
JimyMa:mp-engine-fix-free-cache
Jul 23, 2025
Merged

fix free cache in MPEngine branch#3670
lvhan028 merged 48 commits intoInternLM:mainfrom
JimyMa:mp-engine-fix-free-cache

Conversation

@JimyMa
Copy link
Copy Markdown
Contributor

@JimyMa JimyMa commented Jun 25, 2025

  1. send free signal in decode engine for release cache immediately when migration done
  2. a series of fault tolerance

@lvhan028 lvhan028 requested a review from grimoire June 26, 2025 13:12
@grimoire
Copy link
Copy Markdown
Collaborator

grimoire commented Jul 2, 2025

Please solve the comflicts


logger = get_logger('lmdeploy')

if TYPE_CHECKING:
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this branch?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, creating a branch and using TYPE_CHECKING to import the Engine module avoids circular references while still enabling IDE highlighting and navigation.

Copy link
Copy Markdown
Collaborator

@grimoire grimoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028 lvhan028 merged commit b0b705f into InternLM:main Jul 23, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants