Skip to content

fix gemma3#3772

Merged
lvhan028 merged 4 commits intoInternLM:mainfrom
grimoire:fix-gemma3
Jul 30, 2025
Merged

fix gemma3#3772
lvhan028 merged 4 commits intoInternLM:mainfrom
grimoire:fix-gemma3

Conversation

@grimoire
Copy link
Copy Markdown
Collaborator

Gemma3 does not enable sliding window on every layers. The sliding window block allocation strategy should not be used here.

  • allocation blocks with DefaultBLockManager
  • disable prefix caching if window size > 0
  • fix rope scaling factor

@lvhan028 lvhan028 requested a review from RunningLeon July 28, 2025 02:40
@zhulinJulia24
Copy link
Copy Markdown
Collaborator

gemma3 testcase passed!

Copy link
Copy Markdown
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028 lvhan028 merged commit 1d6854b into InternLM:main Jul 30, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants