Skip to content

fix partial rotary factor #3861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lvhan028 merged 1 commit into from
Aug 21, 2025
Merged

fix partial rotary factor #3861

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lmdeploy/pytorch/nn/rotary_embedding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,10 +107,10 @@ def build_rotary_params(config: PretrainedConfig):
llama3=_get_llama3_parameters)
params.update(build_funcs[rope_type_str](config))

# update partial_rotary_factor
partial_rotary_factor = config.partial_rotary_factor if hasattr(config, 'partial_rotary_factor') else None
if partial_rotary_factor is not None:
params['partial_rotary_factor'] = partial_rotary_factor
# update partial_rotary_factor
partial_rotary_factor = config.partial_rotary_factor if hasattr(config, 'partial_rotary_factor') else None
if partial_rotary_factor is not None:
params['partial_rotary_factor'] = partial_rotary_factor

return params

Expand Down