Merged
Conversation
RunningLeon
reviewed
Sep 12, 2025
RunningLeon
reviewed
Sep 15, 2025
RunningLeon
reviewed
Sep 15, 2025
RunningLeon
reviewed
Sep 15, 2025
RunningLeon
reviewed
Sep 16, 2025
lvhan028
reviewed
Sep 18, 2025
lvhan028
reviewed
Sep 18, 2025
lvhan028
reviewed
Sep 18, 2025
lvhan028
reviewed
Sep 18, 2025
lvhan028
reviewed
Sep 18, 2025
lvhan028
reviewed
Sep 18, 2025
|
|
||
| @logging_timer('SchedulePrefilling', logger) | ||
| def _schedule_prefill(self): | ||
| def _schedule_prefill(self, prealloc_size: int = 0): |
Collaborator
There was a problem hiding this comment.
What's the purpose of prealloc_size? I see it's always passed as 0 from the schedule method. Is this intended for future use or should it be removed?
Collaborator
Author
There was a problem hiding this comment.
Over allocate kv cache might be useful for future models.
Collaborator
|
Does SDAR conflict with --quant-policy fp8? I tried it, it repeated meaningless words. |
Collaborator
|
@zhulinJulia24 may put JetLM/SDAR-8B-Chat, JetLM/SDAR-30B-A3B-Chat into CI |
RunningLeon
reviewed
Sep 18, 2025
lvhan028
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we are refactoring chat template, we will use template of internlm2 for now.