Merged
Conversation
lvhan028
approved these changes
Oct 30, 2025
lvhan028
reviewed
Oct 30, 2025
| input_maker.step() | ||
|
|
||
| async def _async_loop_inputs_preprocess(self): | ||
| async def _async_loop_inputs_preprocess(self, forward_event: asyncio.Event = None): |
Collaborator
There was a problem hiding this comment.
The type of forward_event is supposed to be "lmdeploy.pytorch.engine.engine.CounterEvent", isn't it?
Why we need a _counter for an asyncio.Event?
Collaborator
Author
There was a problem hiding this comment.
The event would be used in engine main loop
lmdeploy/lmdeploy/pytorch/engine/engine.py
Line 1077 in b9ee759
It should not be unlocked before both engine and model agent set the event.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.