Skip to content

Incorrectly judging the request as a bad request#4121

Merged
lvhan028 merged 3 commits intoInternLM:mainfrom
lvhan028:fix-side-effect
Nov 13, 2025
Merged

Incorrectly judging the request as a bad request#4121
lvhan028 merged 3 commits intoInternLM:mainfrom
lvhan028:fix-side-effect

Conversation

@lvhan028
Copy link
Copy Markdown
Collaborator

@lvhan028 lvhan028 commented Nov 12, 2025

Test the following cases

  • case 1
# server
lmdeploy serve api_server
# client
v1/chat/completions + logprobs(true) + top_logprobs(0)
v1/chat/completions + logprobs(true) + top_logprobs(>=1)
v1/chat/completions + logprobs(false) + top_logprobs(0)
v1/chat/completions + logprobs(false) + top_logprobs(>=1)
v1/completions + logprobs(0)
v1/completions + logprobs(>0)
v1/completions + logprobs(<0)
/generate + return_logprobs(true)
/generate + return_logprobs(false)
  • case 2
# server
lmdeploy serve api_server -logprobs-mode raw_logprobs
# client
v1/chat/completions + logprobs(true) + top_logprobs(0)
v1/chat/completions + logprobs(true) + top_logprobs(>=1)
v1/chat/completions + logprobs(false) + top_logprobs(0)
v1/chat/completions + logprobs(false) + top_logprobs(>=1)
v1/completions + logprobs(0)
v1/completions + logprobs(>0)
v1/completions + logprobs(<0)
/generate + return_logprobs(true)
/generate + return_logprobs(false)

@lvhan028 lvhan028 requested a review from irexyc November 13, 2025 07:18
num_logprobs = msg.sampling_param.num_logprobs
cur_logprobs = None
if num_logprobs >= 0:
if logprobs is not None:
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @grimoire
When serving the model by enabling logprobs_mode, if users set logprobs=0 in a request, pytorch engine crashed since logprobs.vals is None

@lvhan028 lvhan028 merged commit 02cd79b into InternLM:main Nov 13, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants