Incorrectly judging the request as a bad request#4121
Merged
lvhan028 merged 3 commits intoInternLM:mainfrom Nov 13, 2025
Merged
Incorrectly judging the request as a bad request#4121lvhan028 merged 3 commits intoInternLM:mainfrom
lvhan028 merged 3 commits intoInternLM:mainfrom
Conversation
irexyc
reviewed
Nov 13, 2025
lvhan028
commented
Nov 13, 2025
| num_logprobs = msg.sampling_param.num_logprobs | ||
| cur_logprobs = None | ||
| if num_logprobs >= 0: | ||
| if logprobs is not None: |
Collaborator
Author
There was a problem hiding this comment.
cc @grimoire
When serving the model by enabling logprobs_mode, if users set logprobs=0 in a request, pytorch engine crashed since logprobs.vals is None
irexyc
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test the following cases