Skip to content

remove get_model_config to avoid pickle hf_config error in rpc calling#4217

Merged
lvhan028 merged 1 commit intoInternLM:mainfrom
lvhan028:fix-side-effect
Dec 18, 2025
Merged

remove get_model_config to avoid pickle hf_config error in rpc calling#4217
lvhan028 merged 1 commit intoInternLM:mainfrom
lvhan028:fix-side-effect

Conversation

@lvhan028
Copy link
Copy Markdown
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@zhulinJulia24
Copy link
Copy Markdown
Collaborator

LGTM test on 3090, passed!

@lvhan028 lvhan028 requested a review from grimoire December 17, 2025 14:05
@lvhan028 lvhan028 merged commit f0fd607 into InternLM:main Dec 18, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants