[AsyncEngine Refactor 1/N] define MultimodalProcessor to handle multimodal data processing#4250
Merged
lvhan028 merged 3 commits intoInternLM:mainfrom Jan 5, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces the MultimodalProcessor class as the first step in refactoring the AsyncEngine architecture. The goal is to extract and consolidate prompt processing logic (both text-only and multimodal) into a dedicated processor component.
Key Changes:
- Introduced
MultimodalProcessorclass to handle prompt preprocessing, message content merging, and multimodal processing - Refactored
VLAsyncEngineandAsyncEngineto delegate prompt processing toMultimodalProcessor - Added
Response.extend()method to replace the standalone_append_response()function - Converted
GenOutto use ato_response()method instead of a standalone conversion function
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lmdeploy/serve/multimodal_processor.py | New file introducing the MultimodalProcessor class that consolidates prompt preprocessing logic for both text and multimodal inputs |
| lmdeploy/serve/vl_async_engine.py | Refactored to delegate prompt processing to MultimodalProcessor and removed duplicate image conversion logic |
| lmdeploy/serve/async_engine.py | Removed prompt processing logic and helper functions; now uses MultimodalProcessor for all prompt handling and updated to use new Response.extend() and GenOut.to_response() methods |
| lmdeploy/messages.py | Added Response.extend() method to enable fluent chaining when accumulating response data |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
irexyc
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist