fix: Pin timm version to avoid failed tests#4258
Merged
lvhan028 merged 1 commit intoInternLM:mainfrom Jan 6, 2026
Merged
Conversation
windreamer
requested review from
lvhan028 and
zhulinJulia24
and removed request for
lvhan028
Collaborator
Author
lvhan028
reviewed
Jan 6, 2026
lvhan028
reviewed
Jan 6, 2026
windreamer
force-pushed
the
fix_pr_test
branch
from
a8312eb to
8a90db3
Compare
lvhan028
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Version 1.0.23 of
timmintroduced a breaking change by removingapply_rot_embedandRotaryEmbeddingexports fromtimm.layers.pos_embed_sincos(see upstream commit huggingface/pytorch-image-models@602634f ). However, the backward compatibility layer intimm.models.layerscontinues to depend on these imports, causing runtime import errors and CI test failures across all pipeline environments.Modification
Lock the
timmdependency to version1.0.22globally across all build and deployment configurations. This version pinning strategy ensures stability and prevents regression while maintaining compatibility with existing code that relies on the deprecated import paths.The change consistently applies version constraints to CI workflows, Docker images, and package requirements files, guaranteeing uniform behavior from development through production environments until upstream compatibility issues are resolved.