Skip to content

fix MPEngine poll#4287

Merged
lvhan028 merged 4 commits intoInternLM:mainfrom
grimoire:fix-mp-engine-poll
Jan 26, 2026
Merged

fix MPEngine poll#4287
lvhan028 merged 4 commits intoInternLM:mainfrom
grimoire:fix-mp-engine-poll

Conversation

@grimoire
Copy link
Copy Markdown
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

Copilot AI review requested due to automatic review settings January 23, 2026 09:41
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the ZMQ-based RPC server loop used by the multi-process PyTorch engine, aiming to improve/repair polling behavior in AsyncRPCServer.run().

Changes:

  • Reworked the server’s poll loop to drain queued socket events via repeated non-blocking polls.
  • Removed the init_event wait when starting streaming RPC calls (now responds with stream_id immediately).
Comments suppressed due to low confidence (1)

lmdeploy/pytorch/engine/mp_engine/zmq_rpc.py:158

  • Removing the init_event wait introduces a race: the client can receive the stream_id and call _asyncrpcserver_get_stream_output before _method_async_streaming_task has populated self.stream_output[stream_id], which will raise ValueError('Stream ID ... not found') and can make streaming calls flaky (e.g., tests/pytorch/engine/test_zmq_rpc.py streaming case). Please ensure the stream state is created before replying (e.g., restore await init_event.wait() before sending the response, or pre-create self.stream_output[stream_id] synchronously in call_method_async and let the task only fill results).
            response = dict(success=True, request_id=request_id, result=stream_id)
            session_id = kwargs.get('session_id', None)
            if session_id is None:
                session_id = args[0]
            self.send_multipart(client_id, response)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lvhan028 lvhan028 requested a review from RunningLeon January 26, 2026 04:56
Copy link
Copy Markdown
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028 lvhan028 merged commit d7458c0 into InternLM:main Jan 26, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants