Skip to content

fix sleep engine for dp=1#4315

Merged
lvhan028 merged 2 commits intoInternLM:mainfrom
RunningLeon:fix-tp-sleep
Feb 3, 2026
Merged

fix sleep engine for dp=1#4315
lvhan028 merged 2 commits intoInternLM:mainfrom
RunningLeon:fix-tp-sleep

Conversation

@RunningLeon
Copy link
Copy Markdown
Collaborator

Motivation

fix sleep engine for dp=1

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the sleep engine functionality when data parallelism (dp) is set to 1 by making synchronization event operations conditional on having multiple data parallel processes.

Changes:

  • Added conditional checks for dp > 1 before awaiting/setting synchronization events in sleep/wakeup methods

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lvhan028 lvhan028 added the Bug:P0 label Feb 2, 2026
@lvhan028 lvhan028 merged commit e22039c into InternLM:main Feb 3, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants