Skip to content

fix fa3 install#4361

Merged
lvhan028 merged 4 commits intoInternLM:mainfrom
irexyc:fix-fa3-install
Feb 26, 2026
Merged

fix fa3 install#4361
lvhan028 merged 4 commits intoInternLM:mainfrom
irexyc:fix-fa3-install

Conversation

@irexyc
Copy link
Copy Markdown
Collaborator

@irexyc irexyc commented Feb 13, 2026

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes the Flash Attention 3 (FA3) installation process in the Docker build script. The changes improve the reliability of FA3 installation by ensuring all required dependencies are explicitly installed and using the --no-index flag to prevent unintended package resolution from PyPI or other indexes.

Changes:

  • Added explicit installation of FA3 dependencies (einops, packaging, ninja) before installing flash_attn_3
  • Changed pip install flags from using -i (alternate index) to --no-index to ensure only the specified wheel repository is used

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lvhan028 lvhan028 merged commit e39d55d into InternLM:main Feb 26, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants