[ascend]adapt for s1-pro dp*tp+ep#4380
Merged
lvhan028 merged 2 commits intoInternLM:mainfrom Mar 4, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adapts the dlinfer (Ascend) backend to support dp*tp+ep parallelism configurations. It makes two changes:
- Adds
FopeRotaryEmbeddingImpl(Fractional Rotary Positional Embedding) support to the dlinfer rotary embedding builder, reusing the default backend's implementation. - Enables group-based router support (
n_groups) inDlinferSoftmaxTopKImplby removing the priorNotImplementedErrorand instead forwardingn_groupstomoe_metadataduring theforwardpass.
Changes:
- Add
FopeRotaryEmbeddingImplsupport forRopeType.Fopein the dlinfer rotary embedding builder. - Remove the
NotImplementedErrorfor group routing inDlinferSoftmaxTopKImpl, storingn_groupsand propagating it tomoe_metadataduring inference.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
lmdeploy/pytorch/backends/dlinfer/rotary_embedding.py |
Imports FopeRotaryEmbeddingImpl from the default backend and adds a RopeType.Fope case to DlinferRotaryEmbeddingBuilder.build, mirroring the default builder. |
lmdeploy/pytorch/backends/dlinfer/moe.py |
Replaces the NotImplementedError for grouped routing with a stored n_groups field and assigns it to moe_metadata.router_n_groups in forward. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
jinminxi104
approved these changes
Mar 4, 2026
lvhan028
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.