ci: integrate clang-format lint into pre-commit hooks#4390
Merged
lvhan028 merged 1 commit intoInternLM:mainfrom Mar 4, 2026
Merged
ci: integrate clang-format lint into pre-commit hooks#4390lvhan028 merged 1 commit intoInternLM:mainfrom
lvhan028 merged 1 commit intoInternLM:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR integrates clang-format linting into the pre-commit hooks to streamline the developer workflow, replacing the separate GitHub Actions step.
Changes:
- Adds a
clang-formatpre-commit hook targeting C/C++/CUDA files undersrc/ - Removes the standalone
DoozyX/clang-format-lint-actionstep from the CI lint workflow
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.pre-commit-config.yaml |
Adds the mirrors-clang-format hook at v11.1.0 scoped to src/ |
.github/workflows/lint.yml |
Removes the old dedicated clang-format GitHub Actions step, now covered by pre-commit run --all-files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lvhan028
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
It is annoying to fix
clang-formatlint each time without pre-commit hooks.Modification
Integrate
clang-formatto pre-commit hooks.