[bugFix] append eos_token_ids in rollout worker manually#1063
Merged
pppppM merged 1 commit intoInternLM:mainfrom Sep 9, 2025
Merged
[bugFix] append eos_token_ids in rollout worker manually#1063pppppM merged 1 commit intoInternLM:mainfrom
pppppM merged 1 commit intoInternLM:mainfrom
Conversation
Collaborator
|
It seems LMDeploy already merged relateve PR InternLM/lmdeploy#3941 into main branch. |
pppppM
approved these changes
Sep 9, 2025
leexinhao
pushed a commit
to leexinhao/xtuner-videochat
that referenced
this pull request
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Append eos_token_ids in rollout worker according to finish reason manually, and this logic will be removed when lmdeploy supports to return stop_tokens