Merged
Conversation
jasagredo
requested review from
a team,
Jimbo4350,
carbolymer,
disassembler,
kevinhammond,
newhoggy and
palas
as code owners
9 tasks
jasagredo
force-pushed
the
utxo-hd-10.4
branch
3 times, most recently
from
da47e9a to
87dd79b
Compare
jasagredo
force-pushed
the
utxo-hd-10.4
branch
4 times, most recently
from
027f9fc to
5d18d39
Compare
Contributor
Author
|
Build failures on Windows are expected due to long paths in |
Contributor
Author
|
Note that the PR description mentions: This is not done yet but will be done before this PR is embarked in the queue. |
carbolymer
approved these changes
Apr 17, 2025
Jimbo4350
reviewed
Apr 17, 2025
| (EpochNo maxBound) | ||
| () | ||
| ( \(AnyNewEpochState sbe nes) _ _ -> do | ||
| ( \(AnyNewEpochState sbe nes _) _ _ -> do |
Contributor
There was a problem hiding this comment.
I think we need to encode the tables here as well. cc: @carbolymer
Contributor
There was a problem hiding this comment.
We can discuss on slack. I wouldn't block the PR on this.
Jimbo4350
approved these changes
Apr 17, 2025
| (EpochNo maxBound) | ||
| () | ||
| ( \(AnyNewEpochState sbe nes) _ _ -> do | ||
| ( \(AnyNewEpochState sbe nes _) _ _ -> do |
Contributor
There was a problem hiding this comment.
We can discuss on slack. I wouldn't block the PR on this.
carbolymer
force-pushed
the
utxo-hd-10.4
branch
2 times, most recently
from
ace1246 to
a832699
Compare
carbolymer
force-pushed
the
utxo-hd-10.4
branch
from
a832699 to
845d382
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist