Skip to content

wb | enable deployment of local commits#6450

Merged
mgmeier merged 1 commit intomasterfrom
bench/cloudy
Feb 25, 2026
Merged

wb | enable deployment of local commits#6450
mgmeier merged 1 commit intomasterfrom
bench/cloudy

Conversation

@fmaste
Copy link
Contributor

@fmaste fmaste commented Feb 20, 2026

Description

Only for "cloud" (*-nomadcloud) profiles.

Allow the use of full Nix store paths instead of flake reference URLs when the commit is unavailable online. Client machines, nodes, and the explorer must be able to access the deployer as a Nix substituter.

This mode is triggered when no commit ID is found (commit "000000...") or when the specified commit doesn’t exist on GitHub. A warning message appears, followed by a prompt to press Enter to continue.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-9.6 and ghc-9.12
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@fmaste fmaste force-pushed the bench/cloudy branch 2 times, most recently from c843b7d to 590afe8 Compare February 24, 2026 15:07
@fmaste fmaste changed the title Bench/cloudy wb | enable deployment of local commits from the deployer Feb 24, 2026
@fmaste fmaste marked this pull request as ready for review February 24, 2026 17:16
@fmaste fmaste requested a review from a team as a code owner February 24, 2026 17:16
@fmaste fmaste changed the title wb | enable deployment of local commits from the deployer wb | enable deployment of local commits Feb 24, 2026
Copy link
Contributor

@mgmeier mgmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @fmaste !

@mgmeier mgmeier added this pull request to the merge queue Feb 25, 2026
Merged via the queue into master with commit 9d6c7ff Feb 25, 2026
30 checks passed
@mgmeier mgmeier deleted the bench/cloudy branch February 25, 2026 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants