Skip to content

(fix#3326): Typo on Voting panel dates#3855

Merged
Ciabas merged 2 commits into
developfrom
3326-typo-on-voting-panel
Jun 30, 2025
Merged

(fix#3326): Typo on Voting panel dates#3855
Ciabas merged 2 commits into
developfrom
3326-typo-on-voting-panel

Conversation

@Ciabas
Copy link
Copy Markdown
Contributor

@Ciabas Ciabas commented Jun 30, 2025

List of changes

  • Fix date format in voting panel.

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

Changes

image

@Ciabas Ciabas requested a review from bosko-m June 30, 2025 10:15
@Ciabas Ciabas self-assigned this Jun 30, 2025
@Ciabas Ciabas requested review from MSzalowski and Ryun1 as code owners June 30, 2025 10:15
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

"backToGovActions": "Back to Governance Actions",
"castVote": "<0>You voted {{vote}} on this proposal</0>\non {{date}} (Epoch {{epoch}})",
"castVoteDeadline": "You can change your vote up to {{date}} (Epoch {{epoch}})",
"castVoteDeadline": "You can change your vote up to {{date}} (UTC, Epoch {{epoch}})",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ciabas I wouldnt put UTC in brackets, but rather right after the date. So {{date}} UTC

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@Ciabas Ciabas merged commit d7ccbb4 into develop Jun 30, 2025
8 checks passed
@Ciabas Ciabas deleted the 3326-typo-on-voting-panel branch June 30, 2025 11:37
@github-actions
Copy link
Copy Markdown
Contributor

@Ciabas
This PR is in the tag: develop-d7ccbb49f7b5dacdb90669bb879fef4bb4af71a9 , for govtool-metadata-validation service

@github-actions
Copy link
Copy Markdown
Contributor

@Ciabas
This PR is in the tag: develop-d7ccbb49f7b5dacdb90669bb879fef4bb4af71a9 , for govtool-backend service

@github-actions
Copy link
Copy Markdown
Contributor

@Ciabas
This PR is in the tag: develop-d7ccbb49f7b5dacdb90669bb879fef4bb4af71a9 , for govtool-frontend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants