This repository was archived by the owner on Dec 2, 2024. It is now read-only.
PLT-646 Removed the TotalFunds effect of WalletEffect.#718
Merged
koslambrou merged 1 commit intomainfrom Sep 22, 2022
Merged
Conversation
koslambrou
force-pushed
the
PLT-646-remove-total-funds-effect-in-wallet-effect
branch
from
f035640 to
b3d9dca
Compare
In short, we won't be using the wallet to query blockchain information. This is the responsability of the indexing component. See our ADRs for more details.
koslambrou
force-pushed
the
PLT-646-remove-total-funds-effect-in-wallet-effect
branch
from
b3d9dca to
1c0672c
Compare
ghost
approved these changes
Sep 22, 2022
koslambrou
deleted the
PLT-646-remove-total-funds-effect-in-wallet-effect
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In short, we won't be using the wallet to query blockchain information. This is the responsability of the indexing component. See ADR-5 for more details.
Pre-submit checklist: