This repository was archived by the owner on Dec 2, 2024. It is now read-only.
PLT-1034 Fixed SealedBidAuction failing quickcheck test case.#767
Merged
koslambrou merged 1 commit intomainfrom Oct 20, 2022
Conversation
berewt
reviewed
Oct 20, 2022
ghost
approved these changes
Oct 20, 2022
* Fixed the SealedBidAuction failing quickcheck test case * Documented the issue concerning validity intervals and outlined the issue with cardano-ledger. * Added a global limit of 100 for number of generated test cases for quickcheck. This can be override on individual property tests using 'withMaxSuccess'. * Added a test case for Crowdfunding to verify that we can't make a contribution if the deadline is elapsed.
koslambrou
force-pushed
the
PLT-1034-gth-759-fix-sealedbidauction-quickcheck-contractmodel-failing-test-case
branch
from
74485f7 to
6e7bfb4
Compare
koslambrou
deleted the
PLT-1034-gth-759-fix-sealedbidauction-quickcheck-contractmodel-failing-test-case
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #759
Fixed the SealedBidAuction failing quickcheck test case
Documented the issue concerning validity intervals and outlined the issue with cardano-ledger.
Added a global limit of 100 for number of generated test cases for quickcheck. This can be override on individual property tests using 'withMaxSuccess'.
Added a test case for Crowdfunding to verify that we can't make a contribution if the deadline is elapsed (unrelated to the fix, but I encountered the lack of test for this test case when looking at the validity intervals)
Pre-submit checklist: