This repository was archived by the owner on Dec 2, 2024. It is now read-only.
Change contractState and instancesState to mutable variables.#786
Merged
koslambrou merged 1 commit intomainfrom Oct 27, 2022
Merged
Change contractState and instancesState to mutable variables.#786koslambrou merged 1 commit intomainfrom
koslambrou merged 1 commit intomainfrom
Conversation
koslambrou
changed the base branch from
main
to
merge-djed-babbage-branch-patches-2
Contributor
sjoerdvisscher
left a comment
sjoerdvisscher
left a comment
There was a problem hiding this comment.
Except for cosmetics I don't feel qualified to review this...
koslambrou
force-pushed
the
merge-djed-babbage-branch-patches-2
branch
from
cadb0af to
0882841
Compare
koslambrou
force-pushed
the
merge-djed-babbage-branch-patches-3
branch
2 times, most recently
from
831a232 to
12dce8c
Compare
This avoids bottleneck when updating InMemInstances, especially when an instance already exists. PutState of InMemInstances is adjusted so as to avoid full map update when instance already exists. Co-authored-by: Jann Müller <j-mueller@users.noreply.github.com>
koslambrou
force-pushed
the
merge-djed-babbage-branch-patches-3
branch
2 times, most recently
from
e017bcb to
bca56c8
Compare
kayvank
pushed a commit
that referenced
this pull request
Oct 27, 2022
This avoids bottleneck when updating InMemInstances, especially when an instance already exists. PutState of InMemInstances is adjusted so as to avoid full map update when instance already exists. Co-authored-by: etiennjf <jean-frederic.etienne@iohk.io> Co-authored-by: Jann Müller <j-mueller@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from:
Summary:
This avoids bottleneck when updating InMemInstances, especially when an instance already exists. PutState of InMemInstances is adjusted so as to avoid full map update when instance already exists.
cc @etiennejf
Pre-submit checklist: