Skip to content
This repository was archived by the owner on Dec 2, 2024. It is now read-only.

PLT-1123: Add evalEmulatorTrace#795

Merged
sjoerdvisscher merged 1 commit intomainfrom
get-emulator-trace-result
Nov 3, 2022
Merged

PLT-1123: Add evalEmulatorTrace#795
sjoerdvisscher merged 1 commit intomainfrom
get-emulator-trace-result

Conversation

@sjoerdvisscher
Copy link
Contributor

@sjoerdvisscher sjoerdvisscher commented Oct 28, 2022 •
edited
Loading

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Formatting, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reference the ADR in the PR and reference the PR in the ADR (if revelant)
    • Reviewer requested

@sjoerdvisscher sjoerdvisscher force-pushed the get-emulator-trace-result branch 2 times, most recently from f215236 to 2d6f8b6 Compare October 28, 2022 12:16
@sjoerdvisscher sjoerdvisscher marked this pull request as ready for review October 29, 2022 12:22
@koslambrou
Copy link
Contributor

koslambrou commented Oct 31, 2022

What's missing is a test case in Spec.Emulator which showcases how it works?

@sjoerdvisscher sjoerdvisscher force-pushed the get-emulator-trace-result branch 3 times, most recently from 395436d to 130c89b Compare November 1, 2022 16:10
@sjoerdvisscher sjoerdvisscher changed the title Add evalEmulatorTrace PLT-1123: Add evalEmulatorTrace Nov 2, 2022
@sjoerdvisscher sjoerdvisscher requested review from a user and koslambrou November 2, 2022 09:49
ghost
ghost approved these changes Nov 2, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

koslambrou
koslambrou reviewed Nov 2, 2022
View reviewed changes
koslambrou
koslambrou reviewed Nov 2, 2022
View reviewed changes
koslambrou
koslambrou reviewed Nov 2, 2022
View reviewed changes
@sjoerdvisscher sjoerdvisscher force-pushed the get-emulator-trace-result branch from 130c89b to b411aa5 Compare November 3, 2022 09:54
@sjoerdvisscher sjoerdvisscher force-pushed the get-emulator-trace-result branch from b411aa5 to b12602e Compare November 3, 2022 10:39
@sjoerdvisscher sjoerdvisscher merged commit 4b51649 into main Nov 3, 2022
@sjoerdvisscher sjoerdvisscher deleted the get-emulator-trace-result branch November 3, 2022 16:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@koslambrou koslambrou koslambrou left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sjoerdvisscher @koslambrou