This repository was archived by the owner on Dec 2, 2024. It is now read-only.
Merged
Conversation
ghost
marked this pull request as ready for review
sjoerdvisscher
approved these changes
Nov 7, 2022
| @@ -1,4 +1,4 @@ | |||
| Slot 0: TxnValidate 43ba666cc8a22a04b63a3b605ce14146dfa5ed999986625ad90c1bc16dabdd84 | |||
| Slot 0: TxnValidate 43ba666cc8a22a04b63a3b605ce14146dfa5ed999986625ad90c1bc16dabdd84 [ ] | |||
Contributor
There was a problem hiding this comment.
Why is this [ ] and not []? Did we log spaces?
Author
There was a problem hiding this comment.
That's interesting, I don't see tracing in the crowdfunding contract.
ghost
mentioned this pull request
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #642 we have switched to cardano-ledger validation rules and we had to turn off the gathering of coverage data as it was unavailable for us anymore since we haven't been running scripts by ourselves — we were using the cardano-ledger library instead.
This PR bumps the cardano-ledger to a version with
evaluateTransactionExecutionUnitsWithLogs— function that exports the trace logs from the scripts executed during the validation phase and reintegrates back the logs into our pipeline.Fixes #768.
Starts tracking the
release/1.0.x-plutus-toolsbranch.Pre-submit checklist: