feat(face): improve reworked face rendering#9
Open
MarcosLesca wants to merge 1 commit into
Open
Conversation
Author
|
Gracias por el issue aprobado. Ya dejé el PR listo y enlazado (Closes #7). No tengo permisos para aplicar labels en el repo upstream desde el fork. Para la proxima (si te gusta el rework) te sumo para que se integren bien los dialogos y la boca al refactor face 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked Issue
Closes #7
🏷️ PR Type
type:bug— Bug fixtype:feature— New feature or enhancementtype:docs— Documentation onlytype:refactor— Code refactoring with no behavior changetype:chore— Maintenance, dependencies, packaging, toolingtype:breaking-change— Breaking change📝 Summary
📂 Changes
ascii-frames.tsui/sidebar/face-builder.tsui/sidebar-mustachi.tsxui/zone-colors.tsconfig.ts🧪 Verification
npx tsc --noEmitnpm pack./mini-local-check.shManual runtime notes:
✅ Contributor Checklist
type:*label.Co-Authored-Bytrailers.💬 Notes for Reviewers
Main review targets:
ui/sidebar/face-builder.tsandascii-frames.ts.