Merged
Conversation
A lot of this stuff with bounding the height of widgets was a consequence of us not being able to calculate the height of text, and wanting to ensure that control widgets had similar metrics; that should now be revisited. In this particular case, this minimum height just seems like extra logic with no clear benefit, and was complicating the EditableLabel stuff in runebender.
This adds a new example, for logging mouse and keyboard events. This is primarily intended as a debugging and testing tool.
* Only account for baseline in Flex if needed Previously we would always leave enough space for all widgets to potentially be baseline aligned, which could cause unintended layout problems when baseline alignment wasn't used. * Apply suggestions from code review Co-authored-by: Leopold Luley <git@leopoldluley.de>
On windows, we persist the existing selection when focus changes. On mac, the behaviour depends on whether or not there was a click. If there was a click, we use the click to determine the selection; otherwise we select the whole buffer. In addition, on mac, we no longer draw the cursor if the selection is not a caret. - fixes #1225 (again) Update druid/src/widget/textbox.rs Co-authored-by: Leopold Luley <git@leopoldluley.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.