Skip to content

31 all inputs rerender on values change#32

Open
mauleb wants to merge 12 commits into
masterfrom
31-all-inputs-rerender-on-values-change
Open

31 all inputs rerender on values change#32
mauleb wants to merge 12 commits into
masterfrom
31-all-inputs-rerender-on-values-change

Conversation

@mauleb

@mauleb mauleb commented Oct 14, 2020

Copy link
Copy Markdown
Contributor

Closes #31

Changes

  • remove form values/errors/keys from context
  • configure a react native friendly event emitter
  • create a useFormField hook

Steps to Test

  • add console logs to the example web Input component
  • verify that when a single input changes, other inputs are unimpacted

@mauleb mauleb requested a review from joshytaco October 14, 2020 12:43
@mauleb mauleb requested review from byhag and removed request for joshytaco October 14, 2020 19:55
@mauleb mauleb requested a review from joshytaco November 13, 2020 14:46
@joshytaco

Copy link
Copy Markdown
Contributor

@mauleb do you still want me to review this lol

Comment thread examples/web/src/App.js

import Dashboard from 'src/views/Dashboard';

const App = () => (

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mauleb please refactor to use TypeScript

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grahamleslie please advise, Brian may push back on this.
cc: @byhag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

All inputs rerender on values change

2 participants