release/1.7.0: add lowercase jedi_cmake_ROOT and atlas_ROOT env vars in modules for backward compatibility; update authorlist in doc conf#1037
Merged
climbfuji merged 2 commits intoJCSDA:release/1.7.0from Mar 20, 2024
Conversation
…ckward compatibility in spack-stack-1.7.0 only
climbfuji
requested review from
AlexanderRichert-NOAA,
RatkoVasic-NOAA,
srherbener and
ulmononian
RatkoVasic-NOAA
approved these changes
Mar 20, 2024
srherbener
approved these changes
Mar 20, 2024
climbfuji
deleted the
feature/release170_backward_compatibility_env_vars
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Provide lowercase
jedi_cmake_ROOTandatlas_ROOTenvironment variables in auto-generated modulefiles for backward compatibility. Note that this is for release 1.7.0 only to facilitate the transition; this change will not be merged back into develop.Update author list in LaTeX rendering of readthedocs. I took the liberty to remain first author here, everyone else is listed in alphabetical order of first name. Completely open to other suggestions, including first author. This isn't super relevant as literally nobody has ever accessed the LaTeX PDF version.
Testing
None
Applications affected
None
Systems affected
None
Dependencies
n/a
Issue(s) addressed
na/
Checklist
These changes have been tested on the affected systems and applications.All dependency PRs/issues have been resolved and this PR can be merged.