Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds macOS PKG installer build and signing capabilities to the build system. It introduces three new build targets for creating signed PKG installers, notarizing them with Apple, and generating unsigned DMG files.
Key Changes
- Added
create-pkgtarget that builds and signs a macOS PKG installer, including code signing of FlatLaf native libraries - Added
notarize-pkgtarget to submit PKG installers to Apple's notarization service - Updated icon file references to use a new directory structure and added version-suffixed icon copies for jpackage compatibility
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <arg line="--app-version ${dmg.version}"/> | ||
| <arg line="--vendor 'jdiskmark'"/> | ||
| <arg line="--dest ${dist.dir}"/> | ||
| <arg line="--resource-dir pkg/macos/images"/> |
There was a problem hiding this comment.
The resource directory path is hardcoded while other paths use properties. Consider defining this as a property for consistency and maintainability.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@tylermlui what is the current error we're seeing on the mac? @copilot can you start a workflow config for macos pkg format on this branch? |
|
@jamesmarkchan I've opened a new pull request, #156, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
this looks good to merge @tylermlui 
|
- Replace jpackage --type pkg with pkgbuild + productbuild to prevent ad-hoc re-signing that wiped Developer ID signatures - Add runtime sub-bundle seal step so libjli.dylib passes notarization - Clean stale app-image dir from jpackage input before bundling - Add preinstall script to remove existing app before fresh install, fixing silent skip when same bundle ID/version already on disk - Add GitHub Actions workflow for automated macOS PKG build and notarize - Bump version to 0.7.2 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Summary of changes