Improvement to make the architecture of V1Beta much cleaner#56
Merged
Conversation
Improvement of the consistency of timer handling.
…rg profile (#57) * Clean-up unused variables for PM5: The `options` variable is duplicate and removed. PM5 does not currently use `controlCallback` so removed. * Split FTMS and PM5 broadcast interval setting: Implement separate broadcast interval settings for PM5 and FTMS profiles to provide more flexibility and make the purpose of this setting clearer * Improve consistency of `config` object injection: The injection of the `config` object as dependency into the peripherals were inconsistent (some used constructor injection some used import statement). This commit cleans this up and harmonies using constructor DI. * Rework CPS and CSC profiles broadcast schedule: Change the broadcast schedule to update new metrics only once per stroke (or after 4 second timeout if no new stroke is detected). Make the schedule interval settings private. Extend CSC and CPS metric update contexts: Include isPauseStart and isSessionStop in the list events updating metrics for CSC and CPS broadcast. * Refactor config validation and migrations: Split the config validator functions to a new file and group migrations into a separate function to improve code readability and maintainability * Add KayakFirst Blue erg profile
removed the indoorbike injection into the config and made it a standalone option
Removed the option injection and made it a stand-alone option
* Switch to central timestamp * Variable cleanup * Added reporting of rest interval type to Fit and tcx * Added HRR2 and VO2Max in Fit-files * Added pause countdowntimer
* Initial Fix/Workaround of the Simultanuous BLE use
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for creating FIT-files, addressing #59 and laberning#129
Removed the dependency of the clients on an all-knowing RowingStatistics.js and made them parse their own metrics (see laberning#107)