Fix hang when exporting at the CLI#10383
Merged
Siedlerchr merged 17 commits intomainfrom Sep 16, 2023
Merged
Conversation
- pass RemotePreferences to handleMultipleAppInstances - Introduce separate call to processArguments() - Add test case convertBibtexToTablerefsabsbib
Siedlerchr
reviewed
Sep 15, 2023
| private final List<ParserResult> parserResults; | ||
|
|
||
| // Written once by processArguments() | ||
| private List<ParserResult> parserResults; |
Member
|
looks good so far, but would need testing with the binary. |
Member
Author
Test was done at #10380 (comment). I wonder whether we could simply do |
Member
Author
|
I tried it with |
Contributor
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
Siedlerchr
approved these changes
Sep 15, 2023
Member
|
the 60s shutdown is normally only the timeout if the tasks were not shutdown before: jabref/src/main/java/org/jabref/gui/Globals.java Lines 118 to 130 in a0e2564 |
Siedlerchr
added a commit
to Jaovitosr/jabref
that referenced
this pull request
Sep 18, 2023
* upstream/main: update javafx to 20.0.2 [Bot] Update journal abbreviation lists (JabRef#10387) Fix hang when exporting at the CLI (JabRef#10383) Add tests for EntryComperatorTest (JabRef#10357) Update CSL styles Remove empty lines One more Refinements Update docs/getting-into-the-code/guidelines-for-setting-up-a-local-workspace/intellij-89-run-with-intellij.md Add some more exports Refine IntelliJ howto Fix localization Adds LaTeX integrity check based on SnuggleTeX Fix casing "macOS" and "JabRef", vendor: JabRef e.V.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10380
There were two issues:
The former was solved by using the right getter (
e4ea759(#10383)), the latter was solved by shutting down the file update monitor18a3cd3(#10383) (refs https://github.com/JabRef/jabref-issue-melting-pot/issues/290).Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)